include google fonts as part of HTML head - Githubissues

adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial

https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html

MIT License

285 stars 548 forks source link

include google fonts as part of HTML head #345

Closed godanny86 closed 2 years ago

godanny86 commented 2 years ago

Description

Removed Google font includes from ui.frontend module
Includes fonts in html header (customheaderlibs.html) for pages
Should improve LCP

Related Issue

Fix for issue #325, replaces PR https://github.com/adobe/aem-guides-wknd/pull/344

Motivation and Context

Improve performance

How Has This Been Tested?

Run locally and in cloud

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

godanny86 commented 2 years ago

@keepthebyte this is a replacement PR for yours. I think this is the safer way to use the Google fonts api and load them via the header.