SITES-3659 - [Odin] Review Dispatcher config for Odin and contribute generic parts - Persisted queries - Githubissues

adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial

https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html

MIT License

282 stars 537 forks source link

SITES-3659 - [Odin] Review Dispatcher config for Odin and contribute generic parts - Persisted queries #366

Closed sandru85 closed 2 years ago

sandru85 commented 2 years ago

GraphQL persisted queries should be cached by default at dispatcher level.

Description

The query parameters sent in the request via dispatcher need to be encoded. One example of such query is https://publish-p33706-e135212.adobeaemcloud.com/graphql/execute.json/aem-cplotusonlinecommerce-project/getMarketingBannersList%3Btag%3Dmarketing-banner-homepage%3Bpath%3D%2Fcontent%2Fdam%2Faem-cplotusonlinecommerce-project%2Fth%2Fen%2Fhome

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

sandru85 commented 2 years ago

@godanny86 do you have any idea why the build is failing? it seems there is no problem with the checksum of the immutable files. default.vhost file is the same as here https://github.com/adobe/aem-project-archetype/pull/946 and the md5 is updated.