adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial
https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html
MIT License
281 stars 533 forks source link

i18n JSON example abandoned - should be fixed to show proper usage #388

Open Ronald-Diemicke opened 1 year ago

Ronald-Diemicke commented 1 year ago

Expected Behaviour

There should be an example on how to use a .json for i18n

Actual Behaviour

https://github.com/adobe/aem-guides-wknd/blob/main/ui.apps/src/main/content/jcr_root/apps/wknd/i18n/fr.json exists as an example, but appears to go unused as it isn't referenced anywhere.

Reproduce Scenario (including but not limited to)

Looking at the live instance, https://wknd.site/fr/fr.html , this never appears.

Steps to Reproduce

Look at the code for a reference to fr.json or at https://wknd.site/fr/fr.html - neither uses the translation available in https://github.com/adobe/aem-guides-wknd/blob/main/ui.apps/src/main/content/jcr_root/apps/wknd/i18n/fr.json

Platform and Version

Current

Sample Code that illustrates the problem

https://github.com/adobe/aem-guides-wknd/blob/main/ui.apps/src/main/content/jcr_root/apps/wknd/i18n/fr.json

Logs taken while reproducing problem

SachinMali commented 1 year ago

The fr.json acts as a dictionary and is mainly used for presenting component UI in different languages, please see details here

However, for the French version of WKND site (multilingual websites), the steps outlined here would be needed.

I am flagging this as an enhancement and will look into prioritization.

Meanwhile for more info on Translation please see