WCM Core Email components added for v6.5

knennigtri commented 1 year ago

Description

New submodule called /email for POC for email pages for ACC/ACS using AEM v6.5.x

components - /apps/wknd/components/email
client library - /apps/wknd/clientlibs/clientlib-email
configuration - /apps/wknd/config/rewriter/email-link-rewrite (core email cmps project said this was required)
email page - /content/campaigns/wknd/master/campaign-emails/wknd-email
template - /conf/wknd/settings/wcm/templates/email-page
template type - /conf/wknd/settings/wcm/template-types/email-page
policies - /conf/wknd/settings/wcm/policies/wknd/components/email
/email/all creates an aem-guides-wknd.email.all-2.1.3-SNAPSHOT.zip and installs:
- /apps/wknd-email-packages/application/install/aem-guides-wknd.email.ui.apps-2.1.3-SNAPSHOT.zip
- /apps/wknd-email-packages/content/install/aem-guides-wknd.email.ui.content-2.1.3-SNAPSHOT.zip
- /apps/wknd-email-vendor-packages/application/install/core.email.components.content-1.0.0.zip
- /apps/wknd-email-vendor-packages/application/install/core.email.components.core-1.0.0.jar
aem-guides-wknd.email.all-2.1.3-SNAPSHOT.zip artifact is added to wknd/all

Feature request: #396

Motivation and Context

Core Email Components are now supported with WCM Core Components v2.21.2. Adobe gives good documentation for them, but a good example is lacking. Using WKND's brand to highlight these components helps developers investigate the components and gain interest.

How Has This Been Tested?

Core email components 1.0.0 requires AEM 6.5.14+ and Core Components v2.21.2

AEM 6.5.14 with this project integrated with ACS successfully sent the email page from AEM to ACS. AEM >> ACC has not been tested

Screenshots (if appropriate):

The example email tries to highlight some of the new WCM Email Core components as well as maintaining the basic layout of the original examples that existed with the We.Retail example.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

SachinMali commented 1 year ago

@knennigtri This is great, however instead of a new submodule (email) can this be a separate project like WKND Shared. This will help to have decoupling and somewhat independent development, and release cycle.

knennigtri commented 1 year ago

@SachinMali this makes sense, I'll just need a bit of guidance (official repo, publishing to maven, etc...) on how to do that.

SachinMali commented 1 year ago

@knennigtri Thanks and sorry for the delay. Please see high-level steps

Create a new repo here https://github.com/adobe/aem-guides-wknd-email (AEM WKND Email Project). We will ask the admins of the Adobe namespace to create for us but for now you can create a local repo and then we just point the origin and push upstream
To integrate into the main WKND we can follow [How to use] (https://github.com/adobe/aem-guides-wknd-shared#how-to-use)-
Update your PR to remove the email module, and its code and only have POM changes related to the above new project repo

adobe / aem-guides-wknd