adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial
https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html
MIT License
282 stars 537 forks source link

sync dispatcher immutable files with Dispatcher SDK and image v2.0.166 #398

Closed krystiannowak closed 1 year ago

krystiannowak commented 1 year ago

sync dispatcher immutable files with Dispatcher SDK and image v2.0.166

Description

Since the previous sync of dispatcher immutable files with Dispatcher SDK and image was from version 2.0.120 in August 2022 and AEM CS releases already progressed further, including dispatcher image and SDK tooling containing newer files, it resulted already in customer using latest public AEM CS releases being out of sync and reporting issues like https://github.com/adobe/aem-project-archetype/issues/1043

Hence we propose to sync those files with the ones from the latest Dispatcher SDK and image v2.0.166 in order for validation scripts not to fail in immutable files compatibility check step as described in https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug.html?lang=en#third-phase

Related Issue

Motivation and Context

Not to fail immutable files validation step described in https://experienceleague.adobe.com/docs/experience-manager-cloud-service/content/implementing/content-delivery/validation-debug.html?lang=en#third-phase when using Dispatcher SDK tooling from the latest AEM CS releases.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

krystiannowak commented 1 year ago

@SachinMali @davidjgonzalez @vladbailescu @gknobloch The changes are currently in Archetype develop via https://github.com/adobe/aem-project-archetype/pull/1045 and will be in Archetype 41 (next to be released) - please review as well

davidjgonzalez commented 1 year ago

@krystiannowak can you re-raise this when 41 is released? WKND stays current to the state of the latest released software (not pre-release, as this is confusing to users that compare their projects using/made from the latest against WKND and see deltas)

krystiannowak commented 1 year ago

@davidjgonzalez ok, so since there are no further sync planned for now to Archetype (until 41 is released) we can have it in draft mode, so I can undraft it when 41 is out (as I am not sure what are current Archetype 41 release plans). But if there are any dispatcher config immutable files further sync, I can also propagate them into this PR (e.g. if some other AEM CS release with even newer Dispatcher SDK tooling and dispatcher-publish image is to be released sooner than Archetype).

Hope it works for you?

/cc: @froesef

krystiannowak commented 1 year ago

@davidjgonzalez Supposedly now Archetype 41 is being cut, containing that change https://github.com/adobe/aem-project-archetype/milestone/34?closed=1

davidjgonzalez commented 1 year ago

@krystiannowak i don't see 41 released yet. Any idea if the release was cancelled?

krystiannowak commented 1 year ago

@davidjgonzalez AFAIK it should be out very soon: https://github.com/adobe/aem-project-archetype/releases/tag/untagged-e99e5072ac10d288221b

davidjgonzalez commented 1 year ago

@krystiannowak that link 404's - did they rollback the release?

krystiannowak commented 1 year ago

@davidjgonzalez https://github.com/adobe/aem-project-archetype/pull/1050

SachinMali commented 1 year ago

@krystiannowak Did anyone cut the release, cause I still see 40 on the https://github.com/adobe/aem-project-archetype/releases unless it's getting published, if so once published we should be good for merge.

krystiannowak commented 1 year ago

@SachinMali It's still in Draft by @barshat7

/cc: @vladbailescu

krystiannowak commented 1 year ago

@davidjgonzalez @SachinMali Archetype 41 is out: https://github.com/adobe/aem-project-archetype/releases/tag/aem-project-archetype-41