Resolved package dependency in classic all project - Githubissues

adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial

https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html

MIT License

285 stars 560 forks source link

Resolved package dependency in classic all project #412

Closed davidjgonzalez closed 1 year ago

davidjgonzalez commented 1 year ago

Fixed issue where aem-guides-wknd-shared.ui.content v3.0.0 was being set as a package dependency even in the -classic artifact.

This fix sets aem-guides-wknd-shared.ui.content v3.0.0 as a dep in the cloud artifact, and v2.2.2 as a dep in the classic artifact.

Note that the aem-guides-wknd.all-3.0.0-classic.zip in https://github.com/adobe/aem-guides-wknd/releases/tag/aem-guides-wknd-3.0.0 contains this fix retroactively.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.