adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial
https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html
MIT License
286 stars 558 forks source link

WKND content spread bad practice wrt to /conf/wknd/settings/wcm #437

Open yann117 opened 9 months ago

yann117 commented 9 months ago

Expected Behaviour

While editing a Page from the WKND sample website, there should not be warning message logged.

Actual Behaviour

When editing any WKND Page, we can find multiple warning messages in the logs, due to missing jcr:content childresource in the templates.

Analysis / Business impact

These messages indicate that some given Pages (primaryType=cq:Page) do not have any jcr:content child node of primaryType=cq:PageContent. Technically it is not enforced, but many implementations rely on it, and therefore a warning is written in such a situation.

The recommendation is to always have a jcr:content for cq:Page, which is not the case for:

Customers taking the WKND sample website as a reference for their own applicative, would ends with the same definition in their applicative template.

Once in production, on the Publishers, this can lead to millions of useless warning messages generated, hindering further analysis of the logs for other important issues.

The WKND code should be fixed to demonstrate the correct definition/structure.

Platform and Version

WKND v3.2.0 (and same in master)

Logs taken while reproducing problem

28.12.2023 12:53:36.764 *WARN* [[0:0:0:0:0:0:0:1] [1703764416762] GET /conf/wknd/settings/wcm/templates/landing-page-template/thumbnail.png.thumb.48.48.png HTTP/1.1] com.day.cq.wcm.core.impl.page.PageImpl page at /conf/wknd/settings/wcm/templates does not have a jcr:content childresource

28.12.2023 12:53:36.764 *WARN* [[0:0:0:0:0:0:0:1] [1703764416762] GET /conf/wknd/settings/wcm/templates/landing-page-template/thumbnail.png.thumb.48.48.png HTTP/1.1] com.day.cq.wcm.core.impl.page.PageImpl page at /conf/wknd/settings/wcm does not have a jcr:content childresource
yann117 commented 9 months ago

@kwin @davidjgonzalez