adobe / aem-headless-client-js

AEM Headless Client for JavaScript
Apache License 2.0
25 stars 12 forks source link

Feature/sdk module and auth #1

Closed easingthemes closed 3 years ago

easingthemes commented 3 years ago

Pull Request Checklist:

bdelacretaz commented 3 years ago

In the meantime @gknob notes that we might (or rather should) base our clients on https://github.com/adobe/aio-sdk-core which already defines things like config, errors, logging etc. and maybe define our own aem-clients-core extending from that and reusing the https://github.com/adobe/generator-aio-app/tree/master/generators patterns.

@easingthemes based on your work on https://github.com/adobe/aio-lib-customer-profile do you see such synergies? If yes I suggest that we discuss this further, or if you can quickly "morph" this PR to take those comments into account that might also be a good starting point.

easingthemes commented 3 years ago

@bdelacretaz I've checked a bit deeper if we can use https://github.com/adobe/aio-sdk-core, and unfortunately every part of it (Config, Errors, Logger) is written for NodeJs only. For now our SDK support both NodeJS and Browser, if we decide to split it, than we can use aio-sdk-core for NodeJS part. Browser part should always stays with minimal dependencies (currently none)