allow custom request headers

jihuang-adobe commented 2 years ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

ghenzler commented 1 year ago

@jihuang-adobe What is your use case that requires to set an additional header? Do you have some intermediate infrastructure that requires that header?

(I'm asking because potentially it could be better to explicitly provide the functionality over this generic approach, but it depends on if it is very specific to your setup or not)

jihuang-adobe commented 1 year ago

Hi @ghenzler. I currently have AEM graphql endpoint behind a proxy. The proxy can potentially take a list of custom headers, so I thought it would be convenient if the AEM Headless Client would accept custom headers as an option.

adobe / aem-headless-client-js