chore: update aem-headless-client dependency to include latest bugfixes

adobe / aem-headless-client-nodejs

AEM Headless Client for Node.js

Apache License 2.0

9 stars 1 forks source link

chore: update aem-headless-client dependency to include latest bugfixes #17

Closed colinscz closed 2 months ago

colinscz commented 2 months ago

Description

Include latest bugfixes from aem-headless-client-js https://github.com/adobe/aem-headless-client-js/commits/main/

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

rbartl-pv commented 2 months ago

@easingthemes : Hi Dragan, just wondering if you may have some hints for the validation error in https://github.com/adobe/aem-headless-client-nodejs/actions/runs/9875264370/job/27278833080?pr=17: npm ERR! request to https://sicrepo/nexus/repository/npm-public/typescript/-/typescript-5.5.3.tgz failed, reason: getaddrinfo EAI_AGAIN sicrepo resp. how this can be fixed if it's not a temporarily problem? Apparently the url https://sicrepo/nexus/repository/npm-public/typescript/-/typescript-5.5.3.tgz doesn't exist anymore but it's also not so clear from me where it's coming from.

easingthemes commented 2 months ago

package-lock is corrupted, maybe you have some firewall all special npmrc rules locally.

https://github.com/adobe/aem-headless-client-nodejs/pull/17/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519L40

Delete package-lock and node_modules dir, run npm i and check if package-lock have correct repo urls.

colinscz commented 2 months ago

@easingthemes : Hi Dragan, just wondering if you may have some hints for the validation error in https://github.com/adobe/aem-headless-client-nodejs/actions/runs/9875264370/job/27278833080?pr=17: npm ERR! request to https://sicrepo/nexus/repository/npm-public/typescript/-/typescript-5.5.3.tgz failed, reason: getaddrinfo EAI_AGAIN sicrepo resp. how this can be fixed if it's not a temporarily problem? Apparently the url https://sicrepo/nexus/repository/npm-public/typescript/-/typescript-5.5.3.tgz doesn't exist anymore but it's also not so clear from me where it's coming from.

That seems to be an issue that I caused on my side. Unfortunately it took as default the wrong registry. Just corrected the package-lock file pointing to the npm public registry instead for the install command and pushed the fix.

cc: @rbartl-pv