test: set width and height on icon imgs - Githubissues

adobe / aem-lib

Apache License 2.0

2 stars 7 forks source link

test: set width and height on icon imgs #55

Open fkakatie opened 6 months ago

fkakatie commented 6 months ago

Description

PageSpeed Insights diagnostics recommends to "[s]et an explicit width and height on image elements to reduce layout shifts and improve CLS."

Currently, the decorateIcon function creates an img tag for SVGs without setting an explicit width or height.

Proposal to set an explicit width and height based on the font size of the containing element (the span).

Test URLs

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.