adobe / aem-modernize-tools

A suite of tools to modernize your AEM Sites implementations off legacy features.
http://opensource.adobe.com/aem-modernize-tools/
Apache License 2.0
64 stars 42 forks source link

Handle/Catch rejects and manage - don't fail promise list fast. #113

Closed bstopp closed 2 years ago

bstopp commented 2 years ago

Description

Add logic to handle rejected items when processing lists. This will allow the UI wait to correctly clear instead of ending early while background processes are still occurring.

Related Issue

Fixes #98.

How Has This Been Tested?

Validated manually through UI testing. (Would prefer unit/automatic tests, but practically impossible)

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #113 (6a743f5) into main (7f6c38f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #113   +/-   ##
=========================================
  Coverage     79.21%   79.21%           
  Complexity      430      430           
=========================================
  Files            34       34           
  Lines          1934     1934           
  Branches        356      356           
=========================================
  Hits           1532     1532           
  Misses          295      295           
  Partials        107      107           
Flag Coverage Δ
unittests 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d43dba0...6a743f5. Read the comment docs.