adobe / aem-modernize-tools

A suite of tools to modernize your AEM Sites implementations off legacy features.
http://opensource.adobe.com/aem-modernize-tools/
Apache License 2.0
64 stars 42 forks source link

Tool throws error, but the session was still getting saved leading to partial conversion #190

Open pasahu opened 2 years ago

pasahu commented 2 years ago

Expected Behaviour

When tools throws error in conversion, the repository session should not be saved. This leads to partial conversion of the page.

Actual Behaviour

Whenever tools throws any error while conversion, the session should not get saved.

Reproduce Scenario (including but not limited to)

Add a non-existing component in the "order.components" page rewrite osgi configuration. Once we run the page conversion, error would be thrown in error.log & status is shown as "failed" in the wizard. Post that if we check the node structure in crx/de, we would see partial changes being saved there.

Steps to Reproduce

Add a non-existing component in the "order.components" page rewrite osgi configuration. Once we run the page conversion, error would be thrown in error.log & status is shown as "failed" in the wizard. Post that if we check the node structure in crx/de, we would see partial changes being saved there.

Platform and Version

Tool Version - 2.1.0

Sample Code that illustrates the problem

Logs taken while reproducing problem