Adding support for Forms Conversion to aem modernize tool

ujjwal5 commented 8 months ago

Description

Added an executor for Form conversion job.
Form conversion job would support following form handling: None [applies an in place component conversion] Restore [Restore form to a state to last structure conversion and then apply component rules] Copy to Target [Copying forms from Source directory to Target directory and then applying component conversion.]

For "Copy to Target" option, we are also copying dam asset node to target folder specific to forms.

NOTE: I had to disable baseline check since a version upgrade was required in ConversionJob model. Will enable it once this is through bumping up the versions as well.

Motivation and Context

Added in the mentioned issue above.

How Has This Been Tested?

Added UTs for the form conversion executor.

Screenshots (if appropriate):

https://github.com/adobe/aem-modernize-tools/assets/7971922/0cc895c8-29a5-47ff-81a9-89aacf3184d0

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (1badeb9) to head (00b51ce). Report is 19 commits behind head on main.

:exclamation: Current head 00b51ce differs from pull request most recent head f240f54

Please upload reports for the commit f240f54 to get more accurate results.

Files	Patch %	Lines
.../modernize/form/job/FormConversionJobExecutor.java	84.78%	5 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #210 +/- ## ============================================ + Coverage 80.48% 80.58% +0.09% - Complexity 505 514 +9 ============================================ Files 39 40 +1 Lines 2245 2292 +47 Branches 413 419 +6 ============================================ + Hits 1807 1847 +40 - Misses 313 318 +5 - Partials 125 127 +2 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-modernize-tools/pull/210/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/adobe/aem-modernize-tools/pull/210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `80.58% <85.41%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ujjwal5 commented 5 months ago

Biggest thing is that the forms code and test resources need to be in sub folders/packages

Moved forms code to form specific folders/packages.

adobe / aem-modernize-tools