adobe / aem-modernize-tools

A suite of tools to modernize your AEM Sites implementations off legacy features.
http://opensource.adobe.com/aem-modernize-tools/
Apache License 2.0
64 stars 42 forks source link

Pagination & No Template Matches #71

Closed bstopp closed 2 years ago

bstopp commented 2 years ago

Description

When testing an issue with the UI, issues were identified with the pagination in adding/removing rows.

That also lead to finding a bug in submitting Full conversion for pages that don't have a matching template.

If the page is selected but doesn't have a matching template, do not attempt to apply the policies (it will possibly fail with bad tree structure.

How Has This Been Tested?

Added unit tests

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #71 (bb228b3) into main (20736ba) will increase coverage by 0.03%. The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
+ Coverage     82.71%   82.74%   +0.03%     
  Complexity      449      449              
============================================
  Files            34       34              
  Lines          1909     1907       -2     
  Branches        350      351       +1     
============================================
- Hits           1579     1578       -1     
+ Misses          227      225       -2     
- Partials        103      104       +1     
Flag Coverage Δ
unittests 82.74% <42.85%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ernize/structure/job/PageStructureJobExecutor.java 87.50% <ø> (-0.38%) :arrow_down:
...e/aem/modernize/job/FullConversionJobExecutor.java 78.89% <33.33%> (+0.71%) :arrow_up:
...m/modernize/job/AbstractConversionJobExecutor.java 76.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70bfd7d...bb228b3. Read the comment docs.