search

adobe / aem-modernize-tools

A suite of tools to modernize your AEM Sites implementations off legacy features.
http://opensource.adobe.com/aem-modernize-tools/
Apache License 2.0
64 stars 42 forks source link

Disable responsive grid of Column Control rewrite #75

Closed bstopp closed 2 years ago

bstopp commented 2 years ago

Description

Disables the responsive option of the ColumnControl rewrite rule.

Motivation and Context

Due to how the rewriting a tree functions, when using the Responsive logic, the parent node order is not preserved. There becomes a conflict between the Column Control order being overwritten by the tree traversal.

codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (dd18905) into main (11909b6) will decrease coverage by 3.28%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #75      +/-   ##
============================================
- Coverage     82.47%   79.18%   -3.29%     
+ Complexity      452      427      -25     
============================================
  Files            34       34              
  Lines          1923     1922       -1     
  Branches        354      353       -1     
============================================
- Hits           1586     1522      -64     
- Misses          231      294      +63     
  Partials        106      106
Flag Coverage Δ
unittests 79.18% <100.00%> (-3.29%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../component/impl/rule/ColumnControlRewriteRule.java 59.42% <100.00%> (-30.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11909b6...dd18905. Read the comment docs.