adobe / aem-modernize-tools

A suite of tools to modernize your AEM Sites implementations off legacy features.
http://opensource.adobe.com/aem-modernize-tools/
Apache License 2.0
64 stars 42 forks source link

Fix Lookup of Service PID #97

Closed bstopp closed 2 years ago

bstopp commented 2 years ago

Description

Incorrectly referenced pid - this fixes the bug.

Related Issue

94

How Has This Been Tested?

Added new test cases.

Types of changes

Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #97 (d223fd7) into main (2e99fe3) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #97   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
  Complexity      427      427           
=========================================
  Files            34       34           
  Lines          1928     1928           
  Branches        355      355           
=========================================
  Hits           1524     1524           
  Misses          296      296           
  Partials        108      108           
Flag Coverage Δ
unittests 79.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rnize/component/rule/ColumnControlRewriteRule.java 59.42% <100.00%> (ø)
.../aem/modernize/structure/rule/PageRewriteRule.java 82.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7482b4f...d223fd7. Read the comment docs.