adobe / aem-react-core-wcm-components-base

Apache License 2.0

18 stars 10 forks source link

Fix dollar sign in TeaserV1 action title #9

Open samuelgomezvaltech opened 2 years ago

samuelgomezvaltech commented 2 years ago

Fixes adobe/aem-react-core-wcm-components-base#6

Removes output of dollar sign before action title on TeaserV1

Description

Cleanup dollar sign and create corresponding unit test

Related Issue

https://github.com/adobe/aem-react-core-wcm-components-base/issues/6

Motivation and Context

Teaser action links output a title that does not correspond to the specification; prepending a dollar sign that, yeah, is a typo.

How Has This Been Tested?

Extended TeaserV1.tests.tsx to check for the HTML from .cmp-teaser__action-container

Ran npm run test with the original code and there is a FAIL on TeaserV1.test.tsx

Then ran again npm run test with the changed code in TeaserV1.tsx and all tests are green.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bec40fd). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   98.21%           
=========================================
  Files             ?       33           
  Lines             ?      393           
  Branches          ?       86           
=========================================
  Hits              ?      386           
  Misses            ?        7           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bec40fd...d6f08e3. Read the comment docs.