adobe / aem-react-core-wcm-components

42 stars 16 forks source link

[List] Last modified date and show description about the page is not displayed in the list. #19

Open khn2475 opened 3 years ago

khn2475 commented 3 years ago

I configured the List react core component and checked show description and show date. When it is checked, it is supposed to show the description and last modified date of pages listed in list component. In List react core component, show description and last modified date is not displayed on the page but it is rendered in json.

Expected result:

image

After configuring the list component in my local:

image

JSON rendition:

image

pfauchere commented 3 years ago

@niekraaijmakers, is it that currently the component expects the booleans to be set to true when instantiating the class in JSX?

https://github.com/adobe/aem-react-core-wcm-components/blob/master/react-base-components/src/authoring/list/v2/ListV2.tsx#L40-L41

Should the expectation of the implementation be that if the field is populated it gets rendered?

pfauchere commented 3 years ago

After discussing with @gabrielwalt , we expect the field to be displayed if the value exists in the JSON object.

pfauchere commented 3 years ago

Internal reference: CQ-4311378