adobe / aem-react-core-wcm-components

42 stars 16 forks source link

[Download] Title and properties of the image in the download is not displayed in the webpage #20

Open khn2475 opened 3 years ago

khn2475 commented 3 years ago

When the download component is configured in the webpage, the title of the image which is uploaded from asset in the download component is not displayed. The image properties such as filename, format and size are not displayed. Title and image properties are rendered in json.

Expected result:

image

After authoring the download component:

image

JSON renditions:

image

pfauchere commented 3 years ago

Similar to [0] it could be that currently the component expects the booleans to be set to true when instantiating the class in JSX. @niekraaijmakers WDYT?

https://github.com/adobe/aem-react-core-wcm-components/blob/master/react-base-components/src/authoring/download/v1/DownloadV1.tsx#L28-L30

[0] https://github.com/adobe/aem-react-core-wcm-components/issues/19#issuecomment-733796439

pfauchere commented 3 years ago

After discussing with @gabrielwalt , we expect the field to be displayed if the value exists in the JSON object.

pfauchere commented 3 years ago

Internal reference: CQ-4311375