adobe / aem-react-core-wcm-components

42 stars 16 forks source link

Feature/ioruntime simplifications 2 #47

Closed niekraaijmakers closed 3 years ago

niekraaijmakers commented 3 years ago

Description

Clean up some invalid XML definitions so checks pass Update dependencies to latest versions Simplify SSR structure using _ow__headers for runtime

Related Issue

Motivation and Context

Fixing build errors with newer versions Keeping dependencies up to date Provide the simplest solution possible to customers in examples

How Has This Been Tested?

Local + unit tests

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f679baf). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage          ?   97.76%           
=========================================
  Files             ?       44           
  Lines             ?      672           
  Branches          ?      141           
=========================================
  Hits              ?      657           
  Misses            ?       15           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f679baf...87158c4. Read the comment docs.