adobe / aem-react-core-wcm-components

42 stars 16 forks source link

ContainerV1 fix #48

Closed niekraaijmakers closed 3 years ago

niekraaijmakers commented 3 years ago

Description

The ContainerV1 isn't working for the author - the placeholder isn't displayed and new components cannot be added.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f679baf). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage          ?   97.76%           
=========================================
  Files             ?       44           
  Lines             ?      672           
  Branches          ?      141           
=========================================
  Hits              ?      657           
  Misses            ?       15           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f679baf...0e39212. Read the comment docs.