adobe / aem-sample-we-retail-journal

We.Retail Journal is a sample showcasing SPA Editing capabilities in AEM using React and Angular
Apache License 2.0
70 stars 69 forks source link

MapTo - @adobe/cq-react-editable-components #64

Closed smo043 closed 4 years ago

smo043 commented 4 years ago

Hello,

MapTo HOC wraps an additional 'div' around the component. We have a use case where Carousel is author-able component and card as another author-able component. Because an additional 'div' is wrapped for both of the components, the layout is breaking.

Is there a way we can toggle on/off the 'div'?

Below is how the structure looks

<div><Carousel><div><Card></Card><div></div></div></Carousel><div></div></div>

echart commented 4 years ago

Hi @SMOHA786 , how do you solve this?

smo043 commented 4 years ago

I wrote a custom wrapper to handle this scenario. I can share it with you incase if you need it.

echart commented 4 years ago

Hi again @SMOHA786, thanks for you quickly answer.

Yes, i'm having the same problem with this div wrapper and i would like to check your solution if you could share.

Thank you,

smo043 commented 4 years ago

Sure will share the github url here

echart commented 4 years ago

up just to ensure that you will not forget 😄

smo043 commented 4 years ago

@echart - Sent you the invitation link, accept it.