search

adobe / aem-sample-we-retail-journal

We.Retail Journal is a sample showcasing SPA Editing capabilities in AEM using React and Angular
Apache License 2.0
70 stars 69 forks source link

Adding request parameter limit #86

Closed sumantapakira closed 4 years ago

sumantapakira commented 4 years ago

Hi @gknobloch and @sharanyavinod,

When the number of pages increase just more than 30 then below error occured.

PayloadTooLargeError: request entity too large at readStream (/Users/zospakir/Projects/AEM/Code/SPA/we-retail/aem-sample-we-retail-journal/react-app/node_modules/raw-body/index.js:155:17) at getRawBody (/Users/zospakir/Projects/AEM/Code/SPA/we-retail/aem-sample-we-retail-journal/react-app/node_modules/raw-body/index.js:108:12)

I have added request parameter which solves it. Please have a look at my PR.

Thanks, Pakira

sharanyavinod commented 4 years ago

Thank you for your contribution! Everything looks good, just a minor suggestion. Also, please review and sign the Adobe CLA. Once signed, you might need to close and reopen the PR to run the check again.

sumantapakira commented 4 years ago

Thank you for your contribution! Everything looks good, just a minor suggestion. Also, please review and sign the Adobe CLA. Once signed, you might need to close and reopen the PR to run the check again.

@sharanyavinod Thanks, I have signed it and now its showing "All checks have passed" as green and "Review required" and "Merging blocked" showing Red, do I still need to close this PR and reopen it again?

sumantapakira commented 4 years ago

@pfauchere , I do not understand why did you close it? There is a bug as I described in the PR description!