adobe / aem-site-template-builder

MIT License
23 stars 7 forks source link

code refactor: zip unified, modules separated, direct commands usage removed, i18n #14

Closed bartoszglow closed 3 years ago

bartoszglow commented 3 years ago

Big code refactor for AEM Site Template Builder.

Description

Refactor includes following improvements:

  1. Fixes #10
  2. Removes usage of zip command, removes bestzip and replaces all with adm-zip.
  3. Removes direct usage of git command (replaced by simple-git).
  4. Provides catches for errors in internal scripts.
  5. Modularized code.
  6. Separated i18n.
  7. Standardize way of logging info and errors.
  8. ESLint integration.
  9. Unit test coverage (100% lines, 98.28% stmts).

I propose to release version 2.1.0 of AEM Site Template Builder when these changes are merged in.

Related Issue

10

Motivation and Context

Changes make script more predictable, reliable and feature proof.

How Has This Been Tested?

Changes tested with 4.0.4 version of Basic Template locally on cloud-ready quick start.

Types of changes

Checklist: