rachitkumar13 commented 3 years ago

fixes: https://github.com/adobe/aem-spa-page-model-manager/issues/2

This is a preliminary PR with intentions to get inputs from other developers.
The apiHost is currently obtained from ModelClient (which may change depending upon the strategy used to expose this host.
The code checks if the apihost is different from the current URL host, if so then load clientlibs async.
A validation is put in place to verify if the editor is in edit mode.

codecov[bot] commented 3 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.75%. The diff coverage is 98.27%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   89.36%   90.11%   +0.75%     
==========================================
  Files          10       11       +1     
  Lines         630      688      +58     
  Branches      173      183      +10     
==========================================
+ Hits          563      620      +57     
- Misses         66       67       +1     
  Partials        1        1

Impacted Files	Coverage Δ
src/EditorClient.ts	`95.91% <ø> (ø)`
src/ModelManager.ts	`86.59% <88.88%> (+0.12%)`	:arrow_up:
src/Constants.ts	`91.66% <100.00%> (+1.66%)`	:arrow_up:
src/MetaProperty.ts	`85.71% <100.00%> (+2.38%)`	:arrow_up:
src/ModelClient.ts	`95.23% <100.00%> (+0.50%)`	:arrow_up:
src/Utils.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d46492...9d7b11e. Read the comment docs.