adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
35 stars 24 forks source link

fix: conditionally add async tag in page editor clientlibs #19

Closed rachitkumar13 closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #19 into master will increase coverage by 0.84%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   90.83%   91.67%   +0.84%     
==========================================
  Files          10       11       +1     
  Lines         622      685      +63     
  Branches      169      182      +13     
==========================================
+ Hits          565      628      +63     
  Misses         56       56              
  Partials        1        1              
Impacted Files Coverage Δ
src/AuthoringUtils.ts 100.00% <100.00%> (ø)
src/Constants.ts 95.65% <100.00%> (+5.65%) :arrow_up:
src/MetaProperty.ts 85.71% <100.00%> (+2.38%) :arrow_up:
src/ModelClient.ts 95.23% <100.00%> (+0.50%) :arrow_up:
src/ModelManager.ts 86.47% <100.00%> (+0.16%) :arrow_up:
src/PathUtils.ts 96.13% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8d2f4f...eed084c. Read the comment docs.

grubyak commented 4 years ago

@rachitkumar13 i have updated github actions (your branch is basing on very old master) and while sonar check is now passing, codecov still requires better coverage, see https://github.com/adobe/aem-spa-page-model-manager/pull/19/checks?check_run_id=1124975929

missing tests for:

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: