adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
35 stars 24 forks source link

feat(modelmanager): enable asynchronous initialization of modelmanager #25

Closed sharanyavinod closed 4 years ago

sharanyavinod commented 4 years ago

Sample usage: Before render of the application -

ModelManager.initializeAsync({
    modelClient: {customModelClient},                                 //optional
    path: "/content/we-retail-journal/react/en.model.json" //optional
});
codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@09a22f5). Click here to learn what that means. The diff coverage is 98.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage          ?   92.62%           
=========================================
  Files             ?       11           
  Lines             ?      705           
  Branches          ?      193           
=========================================
  Hits              ?      653           
  Misses            ?       51           
  Partials          ?        1           
Impacted Files Coverage Δ
src/ModelManager.ts 90.00% <98.70%> (ø)
src/ModelClient.ts 94.73% <100.00%> (ø)
src/ModelStore.ts 91.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09a22f5...3c06fc7. Read the comment docs.

pfauchere commented 4 years ago

I am good with the contribution. Please consider my questions and suggestions

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

94.6% 94.6% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: