search

adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
35 stars 24 forks source link

fix: fetch page model on back nav #29

Closed sharanyavinod closed 4 years ago

sharanyavinod commented 4 years ago

On back navigation, empty page is rendered if model is unavailable. To resolve this, model of the page is fetched and page is rendered.

Fixes #28

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8f833ca). Click here to learn what that means. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   92.37%           
=========================================
  Files             ?       11           
  Lines             ?      708           
  Branches          ?      195           
=========================================
  Hits              ?      654           
  Misses            ?       53           
  Partials          ?        1
Impacted Files Coverage Δ
src/ModelRouter.ts 80.39% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f833ca...fb1bcd5. Read the comment docs.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

5.9% 5.9% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: