SushantBhasin commented 3 years ago

On removing a property (removing text from text component or clearing image from image component), its not not passed to ModelManager which returns update data to component without the property.
Each component only checks the received properties from ModelManager for updating its state
This causes issues where the removed property is still visible on page (https://github.com/adobe/aem-angular-editable-components/issues/20)

This fix adds a null string to removed properties so they can be removed from page after editing

codecov[bot] commented 3 years ago

Codecov Report

Merging #32 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +0.01%     
==========================================
  Files          11       11              
  Lines         708      709       +1     
  Branches      191      191              
==========================================
+ Hits          654      655       +1     
  Misses         53       53              
  Partials        1        1

Impacted Files	Coverage Δ
src/ModelStore.ts	`91.79% <100.00%> (+0.06%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a67b0fd...b68bf1e. Read the comment docs.