adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
34 stars 24 forks source link

Issue/remote app edit #38

Closed sharanyavinod closed 3 years ago

sharanyavinod commented 3 years ago
codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (36b39df) into master (c666c06) will increase coverage by 0.10%. The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   92.38%   92.48%   +0.10%     
==========================================
  Files          11       11              
  Lines         709      732      +23     
  Branches      191      208      +17     
==========================================
+ Hits          655      677      +22     
- Misses         53       54       +1     
  Partials        1        1              
Impacted Files Coverage Δ
src/ModelManager.ts 90.19% <94.44%> (+0.19%) :arrow_up:
src/ModelStore.ts 91.85% <100.00%> (+0.06%) :arrow_up:
src/PathUtils.ts 96.29% <100.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c666c06...36b39df. Read the comment docs.

sharanyavinod commented 3 years ago

please relate to my comments and provide pr description

@grubyak Thanks for the review! I've addressed all of your comments. Please take a look again when possible.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.7% 83.7% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: