Closed sharanyavinod closed 3 years ago
Merging #38 (36b39df) into master (c666c06) will increase coverage by
0.10%
. The diff coverage is96.42%
.
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 92.38% 92.48% +0.10%
==========================================
Files 11 11
Lines 709 732 +23
Branches 191 208 +17
==========================================
+ Hits 655 677 +22
- Misses 53 54 +1
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/ModelManager.ts | 90.19% <94.44%> (+0.19%) |
:arrow_up: |
src/ModelStore.ts | 91.85% <100.00%> (+0.06%) |
:arrow_up: |
src/PathUtils.ts | 96.29% <100.00%> (+0.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c666c06...36b39df. Read the comment docs.
please relate to my comments and provide pr description
@grubyak Thanks for the review! I've addressed all of your comments. Please take a look again when possible.
Kudos, SonarCloud Quality Gate passed!
:tada: This PR is included in version 1.2.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
toAEMPath
: Added new helper for transforming remote path to AEM specific path for enabling routing.This is a stop gap solution and will be removed later.