adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.

Apache License 2.0

33 stars 24 forks source link

fix: Return correct model path on route change #54

Closed IrrationalPattern closed 3 years ago

IrrationalPattern commented 3 years ago

Return correct model path for a URL with query parameters that include dot character on route change

Description

PathUtils.sanitize method reused to get a correct model path from URL on route change

Related Issue

53

How Has This Been Tested?

Unit tested

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

dzmitry-kankalovich commented 3 years ago

Hi all, is there something else that needs to be done before this can be merged and released?

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.3.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: