adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.

Apache License 2.0

33 stars 24 forks source link

fix: handle excluded route path on ModelManager initialize #57

Closed antoantonyk closed 3 years ago

antoantonyk commented 3 years ago

Description

Based on the current implementation, we cannot access the excluded sub page route path on initialize. This is because we are not considering the excluded filter paths on Model Manger initialize.

Related Issue

56

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (f9257ec) into master (643f882) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          11       11           
  Lines         787      787           
  Branches      200      204    +4     
=======================================
  Hits          725      725           
  Misses         62       62

Impacted Files	Coverage Δ
src/ModelManager.ts	`89.81% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8c4be5...f9257ec. Read the comment docs.

antoantonyk commented 3 years ago

@blackbyte-pl @CezCz @grubyak

If no other changes required, could you please share the estimated time of the release?

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.3.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket: