adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
33 stars 24 forks source link

[bug] model JSON of page is retrieved with the wrong path #64

Closed niekraaijmakers closed 2 years ago

niekraaijmakers commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

Package version 1.3.10 upwards. 1.3.9 is working.

To Reproduce Steps to reproduce the behavior: 1: Use SPA editor 1.0 on an AEM instance 2: Load in any page that is not included in the model root JSON so it has to be requested 3: Observe the behaviour (see screenshots)

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

1.3.9: Screenshot 2021-06-29 at 06 36 23

1.3.10+: Screenshot 2021-06-29 at 06 24 24

If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

niekraaijmakers commented 3 years ago

The only reason this doesn't completely break the spa editor is because the sling engine can handle this and still returns a model JSON , but still, this is quite dangerous.

giri-jeedigunta commented 3 years ago

Any further updates on this? same thing happens on publish URL too... if the site is /my-app/us/en/home.html the aem page model sends the request for en.model.json instead of home.model.json which contains in-correct content.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.3.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

giri-jeedigunta commented 2 years ago

Will try out the new version ... thank you !!!!

giri-jeedigunta commented 2 years ago

This is working as expected.