search

adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
35 stars 24 forks source link

Feature/error pages #65

Closed niekraaijmakers closed 3 years ago

niekraaijmakers commented 3 years ago

Provides the possibility to specify error pages (500,404) pages for the SPA editor. compatible with https://adobe-consulting-services.github.io/acs-aem-commons/features/error-handler/index.html.

Screenshot 2021-06-29 at 10 11 39 Screenshot 2021-06-29 at 10 11 22

Screenshot 2021-06-29 at 10 10 38

codecov[bot] commented 3 years ago

Codecov Report

Merging #65 (5e0a4f5) into master (052be87) will not change coverage. The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          11       11           
  Lines         791      791           
  Branches      206      206           
=======================================
  Hits          729      729           
  Misses         62       62
Impacted Files Coverage Δ
src/ModelManager.ts 90.00% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 052be87...5e0a4f5. Read the comment docs.

niekraaijmakers commented 3 years ago

If changes are approved , I will create unit tests.

sharanyavinod commented 3 years ago

@niekraaijmakers Looks good.Please proceed with the tests. Also, please use commitizen for future commits as this helps with updating the changelog/release appropriately.

niekraaijmakers commented 3 years ago

Unit tests added.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: