adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.

Apache License 2.0

33 stars 24 forks source link

fix: window.history updated only on init #81

Closed sharanyavinod closed 2 years ago

sharanyavinod commented 2 years ago

Description

Event listener used for history popState
Updating history for pushState and replaceState only done on ModelManager init and not on package import
Also fixes some linting issues
Package updates

Related Issue

Fixes #60

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (323930c) into master (d1ceca6) will increase coverage by 0.76%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   91.89%   92.66%   +0.76%     
==========================================
  Files          11       11              
  Lines         802      804       +2     
  Branches      211      210       -1     
==========================================
+ Hits          737      745       +8     
+ Misses         65       59       -6

Impacted Files	Coverage Δ
src/ModelManager.ts	`89.22% <100.00%> (+0.04%)`	:arrow_up:
src/ModelRouter.ts	`91.66% <100.00%> (+12.94%)`	:arrow_up:
src/PathUtils.ts	`96.58% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1ceca6...323930c. Read the comment docs.