adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.
Apache License 2.0
33 stars 24 forks source link

fix: check the existence of the window object in places where is not yet verified #86

Closed comanV closed 2 years ago

comanV commented 2 years ago

Adds conditional statements to check the existence of the window object in places where is not yet verified.

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (1295e88) into master (198fcf0) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   92.66%   92.67%   +0.01%     
==========================================
  Files          11       11              
  Lines         804      806       +2     
  Branches      206      204       -2     
==========================================
+ Hits          745      747       +2     
  Misses         59       59              
Impacted Files Coverage Δ
src/ModelRouter.ts 92.00% <100.00%> (+0.33%) :arrow_up:
src/PathUtils.ts 96.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f5439c...1295e88. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.4.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: