adobe / aem-spa-page-model-manager

Interface between Adobe Experience Manager and Single Page Application framework.

Apache License 2.0

35 stars 24 forks source link

feat: export ModelStore for standalone usage #92

Closed anoack93 closed 1 year ago

anoack93 commented 1 year ago

Description

Export of ModelStore was added

Related Issue

91

Motivation and Context

How Has This Been Tested?

I have built the project locally and added it to a sample project where I imported the ModelStore

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

anoack93 commented 1 year ago

@sharanyavinod do I have to find a reviewer myself or how is the process here?

sharanyavinod commented 1 year ago

@anoack93 Could you elaborate on the rationale behind needing standalone usage of ModelStore?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Merging #92 (9a725d8) into master (0e89084) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   92.67%   92.67%           
=======================================
  Files          11       11           
  Lines         806      806           
  Branches      208      204    -4     
=======================================
  Hits          747      747           
  Misses         59       59

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

anoack93 commented 1 year ago

@anoack93 Could you elaborate on the rationale behind needing standalone usage of ModelStore?

I wrote a few lines in the related feature request I have created together with this pull requests (#91 )

In particular we have a project were we are consuming the AEM page API but only for some specific pages and not for the whole webapp. As a result we want to take care of routing and initialization ourselves and not use the ModelManager for that.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: