adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

Lighthouse checks with CircleCI #100

Closed samuelmeuli closed 4 years ago

samuelmeuli commented 5 years ago

Feature Request

Is your feature request related to a problem? Please describe.

It would be nice to integrate Lighthouse into the CircleCI setup so we can test whether PRs decrease the PWA score before merging them.

Describe the solution you'd like

Lighthouse Bot currently only supports Travis CI, but there is an open PR adding CircleCI support (https://github.com/GoogleChromeLabs/lighthousebot/pull/68). I suggest using this solution once the PR is merged.

Are there alternatives?

The lighthouse-ci package looks promising as well, but it would be preferable to use the solution from Google. Lighthouse Bot also provides a nice output of the scores on PRs.