search

adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

Add support for code splitting and static assets #104

Closed samuelmeuli closed 5 years ago

samuelmeuli commented 5 years ago
Q                       A
Fixed Issues? Closes #61, closes #83
Patch: Bug Fix? No
Minor: New Feature? Yes
Major: Breaking Change? No
Tests Added + Pass? No
Documentation Provided Yes
Any Dependency Changes? Yes
License Apache License, Version 2.0

See the newly added doc files for a description of the changes.

Requires https://github.com/facebook/create-react-app/pull/7721 and https://github.com/wcm-io-frontend/aem-clientlib-generator/pull/23 to be merged and released first.

grubyak commented 5 years ago

test-spa-react-react-app: Failed to run task: 'npm run build' failed -- did you see that?

samuelmeuli commented 5 years ago

@grubyak Yeah, it's not working yet because it builds on the code of the currently unreleased PRs. Once they're released, we can update the dependencies and the tests should pass :)

samuelmeuli commented 5 years ago

create-react-app v3.2 is released and includes our change.

samuelmeuli commented 5 years ago

https://github.com/wcm-io-frontend/aem-clientlib-generator/pull/23 has also been merged and released, so this PR can now be reviewed :)