search

adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

Angular Archetype discrepancies with Wknd Events code repo #133

Closed iameduardod closed 4 years ago

iameduardod commented 5 years ago

The angular archetype and overall code structure is fundamentally and operationally different from the Wknd Events repo.

Examples: Router: Wknd vs AEM SPA Archetype Page component: Wknd vs AEM SPA Archetype App Module: Wknd vs AEM SPA Archetype

Which approach is the more correct way of doing AEM SPA apps?

davidjgonzalez commented 5 years ago

@emd2013 these changes looks largely cosmetic. You should start with w/ SPA Archetype and adjust as needed.

The Router may not appear cosmetic on the surface, however the SPA Editor JS SDK (and archetype) was augmented to abstract some of the boilerplate complexity away... for example, the JS SDK exposes the definition of the AemPageRouteReuseStrategy in the WKND tutorial into the SDK provided AemPageRouteReuseStrategy -- same with AemPageDataResolver.

habansal commented 4 years ago

@emd2013 I believe your concern has been addressed and we can close this issue. Let us know otherwise.