search

adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

UTF-8 encoding missing #44

Closed pawan-mittal closed 5 years ago

pawan-mittal commented 5 years ago

UTF-8 encoding missing in in public/index.html.

lydiapuric commented 5 years ago

@pawan-mittal CircleCI failed because you didn't sign yet the Adobe CLA, see https://github.com/adobe/aem-spa-project-archetype/pull/44/checks?check_run_id=54185984. Because you are an Adobe employee, you do not have to sign the CLA. Instead contact Adobe's Open Source Office about the failure by mentioning them on the pull request with @adobe/open-source-office or via email grp-opensourceoffice@adobe.com.

stevengill commented 5 years ago

Hey @pawan-mittal!

I sent you an invitation to this org. Go to https://github.com/adobe and you should see it at the top of the page. Accept it. Once you are in this org, just close and re-open this PR and the check should pass.

pawan-mittal commented 5 years ago

@stevengill thanks a lot for providing access. @lydiapuric Now Adobe CLA Signed :). You can merge now.

pawan-mittal commented 5 years ago

@lydiapuric Thanks. I just committed in test section as well :)