search

adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

Angular/React-built Clientlibs shouldn't us AEM GCC minification #51

Closed davidjgonzalez closed 5 years ago

davidjgonzalez commented 5 years ago

https://github.com/adobe/aem-spa-project-archetype/blob/4ce2eaa02d49cedef6e68a29a5f613360862d9a0/src/main/resources/archetype-resources/angular-app/clientlib.config.js#L28

AEM ships with an old GCC. It doesn't seem wise to run the JS code through AEM's old GCC when, at build time, we have the most modern minification tools at our disposal in the Node ecosystem.

The JS delivered into the clientlib should already be optimized and minified by the webpack build.

pfauchere commented 5 years ago

Thx, we will investigate what is the proper configuration. And as you said, it seems like no configuration should be actually set

pfauchere commented 5 years ago

The clientlib configuration should probably be something like jsProcessor: ["default:none", "min:none"]