search

adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

ui.apps - Wrong vault configuration #69

Closed ittaibaratz closed 5 years ago

ittaibaratz commented 5 years ago

The /apps/APP folder should not use merge mode. This means that when we update our components, those updates will not reflect when we install a newer package.

<filter root="/apps/mysamplespa" mode="merge"/>

lydiapuric commented 5 years ago

@ittaibaratz Thanks for reporting. The filter for apps uses merge mode so this archetype does not destroy any custom data in case you have already an project with the same name. Imagine the use case you start building your spa app and you want to sync at any time with the archetype. Therefore I tend to reject this issue.

godanny86 commented 5 years ago

I have to agree with @ittaibaratz, it has long been a standard that /apps is overwritten every time as is the case with [0] in the aem project archetype. I'm not sure what you mean by "sync" with the archetype?

[0] - https://github.com/adobe/aem-project-archetype/blob/master/src/main/archetype/ui.apps/src/main/content/META-INF/vault/filter.xml

lydiapuric commented 5 years ago

What I mean with sync is if you generate a new version of the archetype to get the latest status and try to update / sync your existing project. If there is no need and the project archetype handles is different, then let's just adjust the vault filter for /apps. no strong feeling here from my side.

pfauchere commented 5 years ago

issue tracked internally by CQ-4266180