fistakus commented 2 years ago

Description

added custom request wrapper and removed unnecessary wrappings
deprecated unused HierarchyUtils#createHierarchyServletRequest

Motivation and Context

New wrapper allows separate ComponentContexts to be set for child pages

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ x ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x ] I have signed the Adobe Open Source CLA.
[ x ] My code follows the code style of this project.
[ x ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ x ] I have read the CONTRIBUTING document.
[ x ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov[bot] commented 2 years ago

Codecov Report

Merging #47 (55039da) into master (9657ed3) will increase coverage by 2.36%. The diff coverage is 92.30%.

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
+ Coverage     79.50%   81.86%   +2.36%     
- Complexity       93       97       +4     
============================================
  Files            10       11       +1     
  Lines           200      204       +4     
  Branches         30       30              
============================================
+ Hits            159      167       +8     
+ Misses           24       20       -4     
  Partials         17       17

Impacted Files	Coverage Δ
.../internal/impl/ComponentContextRequestWrapper.java	`75.00% <75.00%> (ø)`
...e/aem/spa/project/core/internal/impl/PageImpl.java	`77.77% <100.00%> (-0.49%)`	:arrow_down:
...oject/core/internal/impl/utils/HierarchyUtils.java	`85.26% <100.00%> (+5.47%)`	:arrow_up:
...spa/project/core/internal/impl/RemotePageImpl.java	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 973019c...55039da. Read the comment docs.