adobe / aem-spa-project-core

Contains abstraction for core Adobe Experience Manager and Single Page Application interface, the page.

Apache License 2.0

29 stars 29 forks source link

Ensure bundle is installed when `all` package is installed #6

Closed ky940819 closed 4 years ago

ky940819 commented 4 years ago

Fixes #5

Submitting PR to master because there doesn't seem to be a development branch.

This PR:

Updates filevault plugin
Adds validation for the filevault plugin (largely copied from the aem-core-wcm-components project)
Adds definition files for the filevault packages to indicate Adobe as the provider and link to this project (similar to the package metadata for aem-core-wcm-components)
Updates the vault filters for the ui.apps and all modules so that they are mutually exclusive (thus correcting the reported bug).
Changes the package group for the ui.apps module so that both the all and ui.apps are in the same package group, for easier package management.

codecov[bot] commented 4 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage     70.98%   70.98%           
  Complexity       71       71           
=========================================
  Files             7        7           
  Lines           193      193           
  Branches         30       30           
=========================================
  Hits            137      137           
  Misses           39       39           
  Partials         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86a4bfb...e33db72. Read the comment docs.

habansal commented 4 years ago

Many Thanks for your contribution.

This seems to introduce a lot of changes. It is better to have The PR should address the exact issue and have separate issue for any refactor/clean-up. That makes the review easier and history cleaner.

That said, I have raised a new PR with a simple fix addressing the exact issue - https://github.com/adobe/aem-spa-project-core/pull/16