search

adobe / aem-testing-clients

Testing tools for Adobe Experience Manager
Apache License 2.0
50 stars 39 forks source link

Page rule prepares template and site at least once per run #65

Closed dulvac closed 2 years ago

francescomari commented 2 years ago

I looked at the implementation of this rule for the first time, and I have a question. prepare might create a template and a site, but there doesn't seem to be any place where that content is deleted. Is that content left there after the rule runs? Is it deleted somewhere but I'm missing it?

dulvac commented 2 years ago

I looked at the implementation of this rule for the first time, and I have a question. prepare might create a template and a site, but there doesn't seem any place where that content is deleted. Is that content left there after the rule runs? Is it deleted somewhere but I'm missing it?

@francescomari , this is not deleted anywhere and it was not changed in this PR. What this PR does is make sure the content is re-created at least every module execution. Maybe we can revisit the strategy around that in a different PR - it is not without complications.