adobe / aem-upload

Makes uploading to AEM easier, and can be used as a command line executable or required as a Node.js module.
Apache License 2.0
62 stars 15 forks source link

switch to using non-module specific syntax. #103

Closed mfrisbey closed 1 year ago

mfrisbey commented 1 year ago

Description

This library was originally created as a blend between module syntax and non-module syntax. As such, the code wasn't always consistent, and the module's export was all transpiled code (i.e. the unaltered code was not used).

This PR brings all code inline so that the library is not a module, and changes the exports so that the unmodified code is used as its primary export. The transpiled code is still included, and is available in the dist directory (which is also the target for the browser element in package.json).

The original library code can now be used as a dependency in both modules and non-modules.

Related Issue

N/A

Motivation and Context

Simplify debugging and troubleshooting by providing raw code as the export. Increase consistency and ensure that the library is not a module.

How Has This Been Tested?

Unit tests and e2e tests pass locally.

Screenshots (if appropriate):

N/A

Types of changes

Checklist:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: