search

adobe / aemanalyser-maven-plugin

A Maven plugin used by developers who develop Java components for AEMaaCS (AEM as a Cloud Service) during their local Java builds to ensure that their components work correctly in when deployed to AEM as a Cloud Service.
Apache License 2.0
23 stars 20 forks source link

Create analyser which replicates the logic from CQBP-84 #78

Closed kwin closed 3 months ago

kwin commented 3 years ago

The Sonar rule described in https://experienceleague.adobe.com/docs/experience-manager-cloud-manager/using/how-to-use/custom-code-quality-rules.html?lang=en#product-apis-annotated-with-providertype-should-not-be-implemented-or-extended-by-customers is currently only executed in Cloud Manager. It would be helpful to check the code for implementation of interfaces marked as "providertype" even locally.

Recently the check has been raised to Critical severity which triggers issues e.g. in

  1. ACS AEM Commons: https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2604
  2. ACTool: https://github.com/Netcentric/accesscontroltool/issues/584
  3. AEM Easy Content Upgrade (AECU): https://github.com/valtech/aem-easy-content-upgrade/issues/156
kwin commented 1 year ago

Another bunch of issues have been raised recently:

  1. https://github.com/Netcentric/accesscontroltool/issues/671
  2. https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/3185
  3. https://github.com/ist-dresden/composum-nodes/issues/310
  4. https://github.com/adobe/aem-core-wcm-components/issues/2587

Although those issue wouldn't be prevented by such a feature, verifying the fix locally would be a lot easier with an analyser for that.

kwin commented 1 year ago

I opened https://issues.apache.org/jira/browse/SLING-12026 for the implementation of the according Feature Model Analyser.

dporter-moveworks commented 1 year ago

Closed #2587 after updating WCM 2.32.2 -> 2.23.4

kwin commented 3 months ago

This is supported with the bnd plugin provided at https://github.com/apache/sling-org-apache-sling-providertype-bnd-plugin. Outside the scope of the aemanalyser.