Closed cdhoffmann closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
quickConnect@1dbea1d
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## quickConnect #65 +/- ##
===============================================
Coverage ? 75.01%
===============================================
Files ? 36
Lines ? 1833
Branches ? 0
===============================================
Hits ? 1375
Misses ? 458
Partials ? 0
This PR will break QuickConnect as it is now. It is the first PR in a refactor, and clean up for QuickConnect. The next PRs will go off of this branch as well.
Apologize for the giant PR. Merged Main into this branch in order to use the new AssuranceSessionOrchestrator and state management for a few refactors. This PR has the initial refactor to remove some cyclical dependencies and use the new Architecture. There will be more refactors in future PRs. Main thing for this PR is to look at the QuickConnectService and relevant tests.
I spent some time decoupling the Cyclical dependencies from the QuickConnectService but will still need to spend time doing that in the QuickConnectManager / QuickConnectView next.